Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-3332) Correct target validation #400

Merged
merged 1 commit into from
May 19, 2016
Merged

(MODULES-3332) Correct target validation #400

merged 1 commit into from
May 19, 2016

Conversation

hdeheer
Copy link
Contributor

@hdeheer hdeheer commented May 18, 2016

The check should not warn when fragment target is based on concat_file name instead of path.
Previous fix only specifically fixed the case:

concat_file {'a_file': path => '/some/path'}
concat_fragment {'foo': target => '/some/path'}

But it introduced warnings for the case:

concat_file {'a_file': path => '/some/path'}
concat_fragment {'foo': target => 'a_file'}

The check should not warn when target is based on concat_file name instead of path.
@DavidS DavidS merged commit 8f135ad into puppetlabs:master May 19, 2016
@DavidS
Copy link
Contributor

DavidS commented May 19, 2016

Thanks, good catch!

@LukasAud LukasAud added the bugfix label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants