(MODULES-4474) Drop autorequire of fragments in concat_file #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The concat_file type defines an autorequire of related fragments which can unnecessarily lead to dependency cycles. It's not evident why fragments exactly need to be required as the type seems to work fine without it. This commit drops the autorequire that collects fragments in concat_file to prevent these dependency cycles from happening.
|
Thanks @tdevelioglu ! I believe this was a remnant of the T&P changes before we moved some of the magic to eval_generate. |
|
Those dependencies were important; see https://tickets.puppetlabs.com/browse/MODULES-7533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concat_file type defines an autorequire of related fragments which
can unnecessarily lead to dependency cycles.
It's not evident why fragments exactly need to be required as the type
seems to work fine without it.
This commit drops the autorequire that collects fragments in
concat_file to prevent these dependency cycles from happening.