Four commits #433
Merged
Four commits #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 3, 2017 17:57
With path not a key attribute it's possible for multiple concat_file
resources to manage the same path.
For example, this compiles fine and creates a file:
-------foo.pp----------
concat_file { 'foo':
ensure => present,
path => '/tmp/foo',
}
concat_file { 'bar':
ensure => present,
path => '/tmp/foo',
}
-----------------------
tdevelioglu@traveler:/tmp$ puppet apply foo.pp
Notice: Compiled catalog for traveler.ams4.prod.booking.com in
environment production in 0.07 seconds
Notice: /Stage[main]/Main/File[/tmp/foo]/ensure: created
Notice: Applied catalog in 0.02 seconds
This makes :path the namevar for concat_file so we get:
tdevelioglu@traveler:/tmp$ puppet apply foo.pp
Error: Evaluation Error: Error while evaluating a Resource Statement,
Cannot alias Concat_file[bar] to ["/tmp/foo"] at /tmp/foo.pp:6; resource
["Concat_file", "/tmp/foo"] already declared at /tmp/foo.pp:1 at
/tmp/foo.pp:6:1 on node traveler.ams4.prod.booking.com
concat_file. The order parameter does not restrict its values, making it easy for simple mistakes to creep in. This restricts the :order parameter to values that are valid (:alpha, :numeric) so it fails early.
The replace parameter accepts an arbitrary string as opposed to the file type's replace parameter. This restricts the values to the same set that the file resource accepts and replaces: Error: /Stage[main]/Main/Concat_file[/tmp/foo]: Failed to generate additional resources using 'generate': Parameter replace failed on File[/tmp/foo]: Invalid value "foo". Valid values are true, false, yes, no. Error: /Stage[main]/Main/Concat_file[/tmp/foo]: Failed to generate additional resources using 'eval_generate': undefined method `ref' for nil:NilClass with a more easily understandable: Error: Parameter replace failed on Concat_file[/tmp/foo]: Invalid value "foo". Valid values are true, false, yes, no. at /tmp/foo.pp:1 It also lets :ensure_newline inherit Puppet::Parameter::Boolean to make it consistent with the other parameters.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in the first 4 backwards-compatible commits of #428