(MODULES-4264) Update for puppet 4 data types #437
Conversation
|
Actually I should get this on top of #424. Oops. |
manifests/fragment.pp
Outdated
| Variant[String, Stdlib::Compat::String] $target, | ||
| $ensure = undef, | ||
| Optional[Variant[String, Stdlib::Compat::String]] $content = undef, | ||
| Optional[Variant[String, Stdlib::Compat::String, Array]] $source = undef, |
There was a problem hiding this comment.
Add Stdlib::Compat::Array to the variant also?
There was a problem hiding this comment.
Okay. And you too on https://github.com/puppetlabs/puppetlabs-apt/pull/659/files#diff-f0fb8c712e70efd75993654e78e8bd59R8 then :D
manifests/fragment.pp
Outdated
| ) { | ||
| validate_string($target) |
There was a problem hiding this comment.
Instead of straight up removing these, use the validate_legacy function here: https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/lib/puppet/functions/validate_legacy.rb
A description of why/usage: https://github.com/puppetlabs/puppetlabs-stdlib#validate_legacy
hunner
force-pushed
the
puppet4
branch
4 times, most recently
from
b0698be
to
b560943
Compare
metadata.json
Outdated
| @@ -103,7 +103,7 @@ | |||
| "requirements": [ | |||
| { | |||
| "name": "puppet", | |||
| "version_requirement": ">= 3.0.0 < 5.0.0" | |||
| "version_requirement": ">= 4.5.2 < 5.0.0" | |||
There was a problem hiding this comment.
shouldn't this be 4.6.1? As far as I know this is the first puppet4 version that is considered stable. Vox Pupuli bumped everything to 4.6.1. All based on this statement
There was a problem hiding this comment.
Preferably 4.6.1 because yes it works better (mostly around create_resources bugs like https://tickets.puppetlabs.com/browse/PUP-6230), but the 4.5 series was the first that fixed data-in-modules (https://tickets.puppetlabs.com/browse/PUP-6230). I'll check with the gang.
There was a problem hiding this comment.
PE 2016.4 (LTS) includes 4.7 but the previous release 2016.2 (they skipped .3) includes 4.5.2... but according to https://docs.puppet.com/pe/latest/overview_getting_support.html 2016.2 is EOL April 30, 2017 so we could probably just jump straight to 4.7.0 support-wise, and use the older puppet-3 versions of modules for supporting 2016.2 and earlier until they EOL.
The data types for validation are using the puppet 4 types with validate_legacy to check for any legacy types that will be removed on the next release. This should be a backwards-compatible release except that it uses puppet 4's data types and bumps metadata.
|
👍 |
The data types for validation are using the puppet 4 types with
validate_legacy to check for any legacy types that will be removed on
the next release. This should be a backwards-compatible change except
that it uses puppet 4's data types.