Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format force tests #469

Merged
merged 3 commits into from
Oct 12, 2017
Merged

Format force tests #469

merged 3 commits into from
Oct 12, 2017

Conversation

willmeek
Copy link

No description provided.

@tphoney
Copy link
Contributor

tphoney commented Oct 12, 2017

Great work @WhatsARanjit !!

@tphoney tphoney merged commit 045e745 into puppetlabs:master Oct 12, 2017
@willmeek willmeek deleted the format_force_tests branch October 12, 2017 14:12
@johanfleury
Copy link
Contributor

johanfleury commented Oct 25, 2017

Hi.

For a reason I can't explain, this changes make Puppet fail with this message: Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: no parameter named 'format' at [...]/modules/concat/manifests/init.pp:94 on Concat_file[/etc/ssh/sshd_config] at [...]/modules/concat/manifests/init.pp:94 on node foo.

The call to concat can be found here: https://github.com/saz/puppet-ssh/blob/master/manifests/server/config.pp#L16.

Any idea of what could cause this error?


Ok, I found something really strange: I removed every environment directories but the one with the latest concat, and the catalog compiled again.

This is not a concat bug then. Sorry for the noise.

@WhatsARanjit
Copy link

@johanfleury No worries. The concat defined type calls the concat_file native type. Likely the new manifest was deployed but an older version of the type was cached. You can force an update like this:

https://puppet.com/docs/puppet/5.2/environment_isolation.html#generate-types

@willmeek
Copy link
Author

Thanks for reporting @johanfleury and @WhatsARanjit

This is a common problem when updating a module that changes parameters for a native provider (see the upstream Puppet Labs issue). Please try restarting the puppet master (and potentially any affected puppet agents) and try re-running puppet again.

Otherwise to reproduce this issue I would ask that you provide detail on the following Jira ticket: https://tickets.puppetlabs.com/browse/MODULES-5802

In particular:

  • Module and version ( as reported by puppet module list )
  • Manifests used
  • Puppet version
  • Ruby Version
  • Any applicable logs

When we have enough information to replicate this scenario, we can look to fix if necessary.

Thank you.

@LukasAud LukasAud added the bugfix label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants