Cleanup ruby code via rubocop #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmeek
requested review from
pmcmaw,
david22swan,
davidmalloncares and
davinhanlon
eputnam
reviewed
Oct 24, 2017
spec/spec_helper.rb
Outdated
| require 'puppetlabs_spec_helper/module_spec_helper' | ||
|
|
||
| # put local configuration and setup into spec_helper_local | ||
| begin | ||
| require 'spec_helper_local' | ||
| rescue LoadError | ||
| puts 'Spec Helper LoadError' |
There was a problem hiding this comment.
I commented on this in the motd PR puppetlabs/puppetlabs-motd#85
There was a problem hiding this comment.
Thanks Eric, have used this here. Great suggestion!
This commit will add code cleanup as corrected and alerted by rubocop. It also adds rules to execute rubocop on Travis.
willmeek
force-pushed
the
rubocopification
branch
from
9c65f57
to
b56360e
Compare
david22swan
approved these changes
Oct 27, 2017
pmcmaw
approved these changes
Oct 27, 2017
HAIL9000
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will add code cleanup as corrected
and alerted by rubocop. It also adds rules to
execute rubocop on Travis.