-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(MODULES-8088) - newline_spec.rb test expectation update #531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message needs some work as it doesn't really comply with the module Contributor Guidelines
While I can see the code, there are no links or references to understand why this commit should be merged.
|
@glennsarti Are you happy with the changes? |
|
Adhoc Pipeline Passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not have expected that a change in the code would not require a symmetrical change in the test, but that may be outside the scope of this pull request :) Thanks for taking the time to help with this. It's a small change, but important to at least one user.
|
@david22swan Honestly, not really, however I am not a maintainer of this module, so if you're ok with it, so be it. From Contributing Guide
|
|
Thanks @glennsarti, the title has been updated. We are going to merge this PR as it is blocking puppet-agent. However we plan in the upcoming days on scheduling a session regarding all this. So better commit messages etc are on their way! 👍 |
|
Hey @ekinanp just to let you know this change has been merged. |
This commit updates the expected test output. The following feature (71e55c4) updates the test output however this is not necessary and caused failures.