Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-9711) Consistently manage concat with no fragments #661

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

seanmil
Copy link
Contributor

@seanmil seanmil commented Oct 7, 2020

When no concat_fragment resources are specified, concat_file
should manage an empty file. This resolves MODULES-9711 and
MODULES-7371.

@seanmil seanmil requested a review from a team as a code owner October 7, 2020 12:29
@puppet-community-rangefinder
Copy link

concat_file is a type

Breaking changes to this file WILL impact these 1 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 171 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

When no concat_fragment resources are specified, concat_file
should manage an empty file. This resolves MODULES-9711 and
MODULES-7371.
@adrianiurca adrianiurca merged commit 1d95adf into puppetlabs:main Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants