Do not modify metaparams in place

[ekohl]

This can have unexpected side effects and break other code that relies on it. This takes a safer approach by iterating over it.

Fixes: dd88b1a

[puppet-community-rangefinder]

concat_file is a type

Breaking changes to this file WILL impact these 1 modules (exact match):

• saz-ssh

Breaking changes to this file MAY impact these 2 modules (near match):

• puppet3-concat
• puppetlabs-concat

This module is declared in 171 of 576 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[carabasdaniel]

Hi @ekohl,

Thank you for putting up this fix. This change makes sense, however it seems acceptance tests are failing with these changes, can you take a look at the CI logs to identify/fix the problem ?

[ekohl]

Oops, forgot one variable name.

[adrianiurca]

Hey @ekohl, thank you for your contribution!

kind regards,
@adrianiurca