Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MAINT) Drop support for Solaris 10, Windows (7, 8.1), Windows Server 2008 R2 and AIX (5.3, 6.1) #741

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented Sep 14, 2022

Prior to this commit the metadata.json file for this module listed OSs that are not supported by puppet agent as supported. This commit aims to refactor the metadata.json file to only list OSs that are supported by puppet agent.

In this commit:

  • Support for Solaris 10 was dropped.
  • Support for Windows 7 and 8.1 was dropped.
  • Support for Windows Server 2008 R2 was dropped.
  • Support for AIX 5.3 and 6.1 was dropped.

The list of supported OSs can be found here:
https://puppet.com/docs/pe/2021.7/supported_operating_systems.html

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned elsewhere, please be descriptive in your commit summary. This isn't just a refactoring, it's dropping support.

@jordanbreen28 jordanbreen28 changed the title (MAINT) Refactoring OSs based on puppet agent docs (MAINT) Drop support for Solaris 10, Windows (7, 8.1), Windows Server 2008 R2 and AIX (5.3, 6.1) Sep 16, 2022
Prior to this commit the metadata.json file for this module listed OSs that are not supported by puppet agent as supported.
This commit aims to refactor the metadata.json file to only list OSs that are supported by puppet agent.

In this commit:
- Support for Solaris 10 was dropped.
- Support for Windows 7 and 8.1 was dropped.
- Support for Windows Server 2008 R2 was dropped.
- Support for AIX 5.3 and 6.1 was dropped.

The list of supported OSs can be found here:
https://puppet.com/docs/pe/2021.7/supported_operating_systems.html
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit 77a8e28 into main Sep 21, 2022
@david22swan david22swan deleted the maint-os_refactor branch September 21, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants