Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-3522) Removing redundant 'requires' #755

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

LukasAud
Copy link
Contributor

@LukasAud LukasAud commented Mar 8, 2023

Prior to this commit, there was an issue regarding the loading of the puppet/type/file/owner constant under certain circumstances during agent runs.

This commit aims to modernise the file request to comply with best practices.

Prior to this commit, there was an issue regarding the loading of the
puppet/type/file/owner constant under certain circumstances during agent
runs.

This commit aims to modernise the file request to comply with best
practices.
@LukasAud LukasAud added the bugfix label Mar 8, 2023
@LukasAud LukasAud requested a review from a team as a code owner March 8, 2023 13:30
@puppet-community-rangefinder
Copy link

concat_file is a type

Breaking changes to this file WILL impact these 1 modules (exact match):
Breaking changes to this file MAY impact these 2 modules (near match):

This module is declared in 169 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@LukasAud LukasAud changed the title (MODULES-3522) Updating constant (MODULES-3522) Removing redundant 'requires' Mar 8, 2023
@pmcmaw pmcmaw merged commit f42c014 into main Mar 9, 2023
@pmcmaw pmcmaw deleted the MODULES-3522-Updating_constant branch March 9, 2023 09:15
@canihavethisone
Copy link

This change appears to have created issue as reported at #758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants