Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puppet5: drop remnants of puppet5 code #761

Merged
merged 1 commit into from
Mar 20, 2023
Merged

puppet5: drop remnants of puppet5 code #761

merged 1 commit into from
Mar 20, 2023

Conversation

b4ldr
Copy link
Collaborator

@b4ldr b4ldr commented Mar 15, 2023

puppet 5 support was dropped sometime ago. This PR simply removes some old code which was around to support puppet5's lack of deferred functions

@b4ldr
puppet5: drop remnants of puppet5 code
5533be5 
puppet 5 support was dropped sometime ago.  This PR simply removes some
old code which was around to support puppet5's lack of deferred
functions
@b4ldr b4ldr requested a review from a team as a code owner March 15, 2023 16:19
@puppet-community-rangefinder
Copy link

concat::fragment is a type

Breaking changes to this file WILL impact these 540 modules (exact match):
Breaking changes to this file MAY impact these 101 modules (near match):

This module is declared in 169 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@b4ldr b4ldr mentioned this pull request Mar 15, 2023
Merged
LukasAud
LukasAud approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 393b816 into puppetlabs:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasAud LukasAud LukasAud approved these changes

Assignees
No one assigned
Labels
bugfix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b4ldr @LukasAud @ia-content