Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-775) Puppet 8 support / Drop Puppet 6 support #768

Merged
merged 28 commits into from
Apr 12, 2023

Conversation

LukasAud
Copy link
Contributor

This PR aims to update the module with compatibility for the upcoming
Puppet 8 agent release. The most relevant changes introduced in this
updated are:
Updated version requirements in metadata.json
Bumped Rubocop gems
Adjusted Rubocop configuration
Resolved new Rubocop offenses

@LukasAud LukasAud requested a review from a team as a code owner April 11, 2023 16:00
@puppet-community-rangefinder
Copy link

concat_file is a type

Breaking changes to this file WILL impact these 1 modules (exact match):
Breaking changes to this file MAY impact these 2 modules (near match):

This module is declared in 169 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Contributor

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordanbreen28 jordanbreen28 merged commit 8b396ca into main Apr 12, 2023
@jordanbreen28 jordanbreen28 deleted the CONT-775-Puppet_8_support branch April 12, 2023 15:50
@LukasAud LukasAud changed the title (CONT-775) Puppet 8 support (CONT-775) Puppet 8 support / Drop Puppet 6 support Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants