remove undocumented requirement to include concat::setup in manifest #77
Conversation
|
This patch passed the rspec-system tests with the default box. |
| $safe_name = regsubst($name, '[/\n]', '_', 'GM') | ||
| $safe_target_name = regsubst($target, '[/\n]', '_', 'GM') | ||
| $concatdir = $concat::setup::concatdir | ||
| $fragdir = "${concatdir}/${safe_target_name}" | ||
|
|
||
| $safe_group = $group ? { | ||
| undef => $concat::setup::root_group, | ||
| default => $safe_group, |
There was a problem hiding this comment.
Maybe I'm just losing my mind here but.. wouldn't this need to be default => $group, otherwise you're saying "If $group is set, set $safe_group to $safe_group which is nil right now. right? Or am I going crazy here.
Unless the class `concat::setup` has been manually included into the
manifest before using the `concat` / `concat::fragment` defined types,
the puppet master will generate this warning while compiling the catalog.
Tue Oct 15 14:05:06 -0700 2013 Scope(Concat[/etc/exports]) (warning):
Could not look up qualified variable 'concat::setup::root_group'; class
concat::setup has not been evaluated
The need to `include concat::setup` directly into the manifest has never
been part of the documented API.
|
I've fixed that error (note: the logic around setting the gid to 0 when your root seems a bit odd -- are there really that many systems out their without a 'root' group defined in |
|
@apenney Is this changeset now acceptable or would you like further iteration? |
|
Looks OK to me, I meant to merge this but I'm drowning in PRs :) |
remove undocumented requirement to include concat::setup in manifest
|
Thank you! |
Unless the class
concat::setuphas been manually included into themanifest before using the
concat/concat::fragmentdefined types,the puppet master will generate this warning while compiling the catalog.
The need to
include concat::setupdirectly into the manifest has neverbeen part of the documented API.