Revert "Correct Naming/AccessorMethodName"

[alexjfisher]

This reverts commit bc6478a.

The API is sensitive_parameters, we can't just change the name of this method in this type because rubocop complains.

[puppet-community-rangefinder]

concat_fragment is a type

Breaking changes to this file WILL impact these 8 modules (exact match):

• simp-at
• simp-cron
• southalc-podman
• example42-icinga
• simp-network
• simp-named
• saz-ssh
• example42-nagios

Breaking changes to this file MAY impact these 12 modules (near match):

• mcanevet-hostapd
• treydock-edac
• panaceya-dhcp
• aswen-icinga
• zordrak-puppet
• simp-snmpd
• simp-postgresql
• simp-openldap
• simp-ganglia
• simp-nscd
• puppet3-concat
• puppetlabs-concat

This module is declared in 169 of 580 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[natemccurdy]

Thanks for the fast turn around @alexjfisher

Though I wonder if there's an rspec test that could be added to catch a regression in expected behavior for the future.

I could try to add one later today when I find the time.

[LukasAud]

Ah yes, this is another revert I was planning to take a look at. LGTM