Param validation #83
Merged
Param validation #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 22, 2013 09:27
In addition, the warn param has been split into a warn (a bool) and warn_message (a string).
Introduction of stdlib functions makes support of puppet < 2.7 impractical.
To be more consistent with other PL modules
|
Travis failed, and without even looking further I know it means there's a trailing , - the most annoying ruby 1.8 thing in the world :( Any chance you can slice it off so travis is happy? |
|
Looks like 1.8.7 is unhappy about default values in block params... fixing it. |
|
I manually tested with ruby 1.8.7 / puppet 2.7.1 (seems 2.7.0 isn't available as a gem). In addition to the default values on block params there was a trailing comma on a define declaration. :) |
|
Boom! |
This was referenced Oct 23, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds validation of all
concatandconcat::fragmentparameters. In addition, the deadgnuparam is removed fromconcatand thewarnparam toconcat::fragmenthas been split intowarnandwarn_message.concat::setupis now considered a private class and directly including it into the manifest will cause afail().It also adds fairly comprehensive rspec-puppet tests for the entire module. There are several pieces of logic that are suspect but the tests were written to model the present behaviour, even if that isn't ideal. Test coverage for the facts is notably absent as is a cleanup of the documentation.