only backup target concat file + remove backup param from concat::fragme... #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gment Disable filebucket backup of all file resources except for the the target file that's being concatenated.
|
Instead of disabling I think we should tear it out. I don't approve of the idea of backing up fragments and I think I'm happy to take an opinionated stance that this should be torn out. |
|
The file resource defaults to using the 'puppet' bucket if not specified. You have to set the param to false to disable bucketing. The only thing this PR leaves configurable is the backup param on the file resource for the final destination. I assumed that someone must have been using it for it to be in the module? |
|
Ah ok, I misunderstood and a quick read made me think that it made the backup for fragments optional for now. In that case I'll merge this as is and we can go from there. |
apenney
pushed a commit
that referenced
this pull request
Oct 23, 2013
only backup target concat file + remove backup param from concat::fragme...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...nt
Disable filebucket backup of all file resources except for the the
target file that's being concatenated.