remove default owner/user and group values #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of $::id to set the default user/owner and group has caused multiple bugs in the past, is incorrectly used to infer the egid, introduces a dependency on the `id` fact, and provides no functionally that can't be accomplished by passing `undef` or not setting the respective params on the file & exec types. A possible alternative would be to introduce a dep on the $::gid fact but that would mean the entire module would depend on a version of facter than hasn't shipped yet (unworkable) or to add a gid/egid fact into this module (ugly).
apenney
pushed a commit
that referenced
this pull request
Oct 24, 2013
remove default owner/user and group values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of $::id to set the default user/owner and group has caused
multiple bugs in the past, is incorrectly used to infer the egid,
introduces a dependency on the
idfact, and provides no functionallythat can't be accomplished by passing
undefor not setting therespective params on the file & exec types.
A possible alternative would be to introduce a dep on the $::gid fact
but that would mean the entire module would depend on a version of
facter than hasn't shipped yet (unworkable) or to add a gid/egid fact
into this module (ugly).