add deprecation warnings on removed parameters + warn on inclusion of co... #90
Conversation
|
This PR was motivated by the discussion in #89 |
| @@ -11,7 +11,7 @@ | |||
| # | |||
| class concat::setup { | |||
| if $caller_module_name != $module_name { | |||
| fail("Use of private class ${name} by ${caller_module_name}") | |||
| warning("Use of private class ${name} by ${caller_module_name}") | |||
There was a problem hiding this comment.
I think we can probably come up with a better explanation here as this is so frequently used, something along the lines of an explanation that we're moving to having concat be the entry class going forward and concat::setup will eventually stop being usable directly. Just something a bit more enduser friendly.
There was a problem hiding this comment.
Agreed. I was in a hurry to get something up quickly for comments.
|
I've updated the warning strings and added integration tests. This doesn't cover the $warn param split up -- do we need to do something around that or perhaps even back that change out? |
add deprecation warnings on removed parameters + warn on inclusion of co...
|
I think it's OK as is, it's really just the concat::setup thing people are concerned about. |
...ncat::setup