New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to depend on puppetlabs-create_resources #4

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@vStone

vStone commented Jan 31, 2012

By adding a dummy class, we can require / include the puppetlabs-create_resources class to make sure the function will be available to abuse.

Some documentation/example that could be added:

case $::puppetversion {
    /^2.7/:   {}
    default:  {
        require puppetlabs-create_resources
    }
}
@nanliu

This comment has been minimized.

Show comment
Hide comment
@nanliu

nanliu Jan 31, 2012

It doesn't quite work this way.

  1. Pluginsync isn't discriminate whether you have this class included or not.
  2. Functions only run on the puppet master, this provides no real value on the agent, unless you apply manifests on the agent rather than catalogs.
  3. You would only install this module for Puppet master below 2.7.0.

nanliu commented Jan 31, 2012

It doesn't quite work this way.

  1. Pluginsync isn't discriminate whether you have this class included or not.
  2. Functions only run on the puppet master, this provides no real value on the agent, unless you apply manifests on the agent rather than catalogs.
  3. You would only install this module for Puppet master below 2.7.0.
@vStone

This comment has been minimized.

Show comment
Hide comment
@vStone

vStone Jan 31, 2012

Hm, I'll try to investigate a little further then on why it failed for me before. Thx for the feedback. Closing request for now.

vStone commented Jan 31, 2012

Hm, I'll try to investigate a little further then on why it failed for me before. Thx for the feedback. Closing request for now.

@vStone vStone closed this Jan 31, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment