Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for RedHat based OSes #3

Merged
merged 60 commits into from May 6, 2014

Conversation

Projects
None yet
3 participants
@actionjack
Copy link
Contributor

actionjack commented Jun 25, 2013

Hi

I've added a support for RedHat based OSes e.g. Redhat, CentOS and Amazon linux and I'm hoping you'll be ok to accept this pull request (I've tried to make the changes discrete and easy to understand.

Changes:

  • I've written the test suite using asserts based on the original module so it won't break anyone who is using it currently.
  • It uses the same sane defaults for Debian and has been updated to handle ruby 1.9.x.
  • Travis CI support has been added.
  • All options have now be parameterized.
  • Puppet-lint fixes.

Cheers

-Martin

actionjack added some commits Jun 21, 2013

@jbouse

This comment has been minimized.

Copy link
Contributor

jbouse commented Feb 3, 2014

While I'm finding a few minor issues with this on my Debian-based systems I think this is a solid PR and should hopefully get merged and spark some life into this module. I'm going to work on a PR to address the Debian issues rebasing off of this.

hunner added a commit that referenced this pull request May 6, 2014

Merge pull request #3 from actionjack/master
Added support for RedHat based OSes

@hunner hunner merged commit 638e076 into puppetlabs:master May 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.