-
Notifications
You must be signed in to change notification settings - Fork 309
Comparing changes
Open a pull request
base repository: puppetlabs/puppetlabs-docker
base: v5.1.0
head repository: puppetlabs/puppetlabs-docker
compare: v6.0.0
- 17 commits
- 35 files changed
- 8 contributors
Commits on Oct 26, 2022
-
(maint) Hardening manifests and tasks
This PR aims to implement some changes that ensure no malformed commands are passed through to the system. Certain commands were left undivided as the commands did not get correctly interpreted. Primarily, the commands targeted were the ones related to Open3 and exec.
Configuration menu - View commit details
-
Copy full SHA for 26e242e - Browse repository at this point
Copy the full SHA 26e242eView commit details -
Prior to this commit lint would not work properly in Github Actions. This commit aims to fix the problems that cause failure in CI.
Configuration menu - View commit details
-
Copy full SHA for 9dbc13b - Browse repository at this point
Copy the full SHA 9dbc13bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c1562f - Browse repository at this point
Copy the full SHA 1c1562fView commit details -
Remove unsupported puppet 5 code
Prior to this commit, there was a block of code checking for puppet 5, which we no longer support. This commit aims to clean up this unnecesary code in order to keep the module tidy.
Configuration menu - View commit details
-
Copy full SHA for 40f1a09 - Browse repository at this point
Copy the full SHA 40f1a09View commit details
Commits on Oct 28, 2022
-
Merge pull request #863 from puppetlabs/maint-codebase-hardening
(maint) Hardening manifests and tasks
Configuration menu - View commit details
-
Copy full SHA for ba2c378 - Browse repository at this point
Copy the full SHA ba2c378View commit details
Commits on Nov 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4916edd - Browse repository at this point
Copy the full SHA 4916eddView commit details
Commits on Nov 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c173a3c - Browse repository at this point
Copy the full SHA c173a3cView commit details -
Attempt to escape things in on OS dependant way
Ruby Shellwords#shellescape "Escapes a string so that it can be safely used in a Bourne shell command line". This is fine for a UNIX like operating system, but windows does not complies with this. Attempt to fix CI by manually "escaping" strings on windows (i.e. quote them and escape quotes with a backslash), and relying on shellescape for other operating systems.
Configuration menu - View commit details
-
Copy full SHA for b5082c2 - Browse repository at this point
Copy the full SHA b5082c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dd5a52 - Browse repository at this point
Copy the full SHA 3dd5a52View commit details -
Always pass subject to stdlib escape function
At the cost of one more function call, we gain in readability and what the docker::escape functions is more straightforward.
Configuration menu - View commit details
-
Copy full SHA for 3d5d645 - Browse repository at this point
Copy the full SHA 3d5d645View commit details -
Escaped strings should not be quotted. While here, also rework the way networks are escaped: the previous code was generating invalid parameters.
Configuration menu - View commit details
-
Copy full SHA for e848283 - Browse repository at this point
Copy the full SHA e848283View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f09d92 - Browse repository at this point
Copy the full SHA 3f09d92View commit details -
Merge pull request #869 from puppetlabs/GH-811-reimplement_reverted_PR
docker_run_flags: Shellescape any provided values
Configuration menu - View commit details
-
Copy full SHA for 088cb33 - Browse repository at this point
Copy the full SHA 088cb33View commit details
Commits on Nov 21, 2022
-
(CONT-263) Bumping required puppet version
Prior to this commit, as part of the codebase hardening project, an important piece of update was missed: raising the minimum required puppet version to 6.24.0, so that certain command breakdowns could occur. This commit aims to fix that. It can also be considered part of the ticket CONT-263 and the final update required before a major release can be cut.
Configuration menu - View commit details
-
Copy full SHA for 17c7668 - Browse repository at this point
Copy the full SHA 17c7668View commit details -
Merge pull request #871 from puppetlabs/CONT-263-Required_minimum_ver…
…sion_bump (CONT-263) Bumping required puppet version
Configuration menu - View commit details
-
Copy full SHA for f008965 - Browse repository at this point
Copy the full SHA f008965View commit details -
GitHub Action committed
Nov 21, 2022 Configuration menu - View commit details
-
Copy full SHA for 36f9e29 - Browse repository at this point
Copy the full SHA 36f9e29View commit details -
Merge pull request #873 from puppetlabs/release-prep
Release prep v6.0.0
Configuration menu - View commit details
-
Copy full SHA for d8445c6 - Browse repository at this point
Copy the full SHA d8445c6View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v5.1.0...v6.0.0