Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-docker
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.1.0
Choose a base ref
...
head repository: puppetlabs/puppetlabs-docker
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.0.0
Choose a head ref
  • 17 commits
  • 35 files changed
  • 8 contributors

Commits on Oct 26, 2022

  1. (maint) Hardening manifests and tasks

    This PR aims to implement some changes that ensure no malformed commands
    are passed through to the system. Certain commands were left undivided
    as the commands did not get correctly interpreted.
    
    Primarily, the commands targeted were the ones related to Open3 and exec.
    LukasAud committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    26e242e View commit details
    Browse the repository at this point in the history
  2. (MAINT) Apply lint autofixes

    Prior to this commit lint would not work properly in Github Actions.
    
    This commit aims to fix the problems that cause failure in CI.
    LukasAud committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    9dbc13b View commit details
    Browse the repository at this point in the history
  3. Suggestions applied 1

    LukasAud committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    1c1562f View commit details
    Browse the repository at this point in the history
  4. Remove unsupported puppet 5 code

    Prior to this commit, there was a block of code checking for puppet 5,
    which we no longer support.
    
    This commit aims to clean up this unnecesary code in order to keep the
    module tidy.
    LukasAud committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    40f1a09 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Merge pull request #863 from puppetlabs/maint-codebase-hardening

    (maint) Hardening manifests and tasks
    david22swan authored Oct 28, 2022
    Configuration menu
    Copy the full SHA
    ba2c378 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Configuration menu
    Copy the full SHA
    4916edd View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Configuration menu
    Copy the full SHA
    c173a3c View commit details
    Browse the repository at this point in the history
  2. Attempt to escape things in on OS dependant way

    Ruby Shellwords#shellescape "Escapes a string so that it can be safely
    used in a Bourne shell command line".  This is fine for a UNIX like
    operating system, but windows does not complies with this.
    
    Attempt to fix CI by manually "escaping" strings on windows (i.e. quote
    them and escape quotes with a backslash), and relying on shellescape for
    other operating systems.
    smortex committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    b5082c2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3dd5a52 View commit details
    Browse the repository at this point in the history
  4. Always pass subject to stdlib escape function

    At the cost of one more function call, we gain in readability and what
    the docker::escape functions is more straightforward.
    smortex committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    3d5d645 View commit details
    Browse the repository at this point in the history
  5. Fix escaped string usage

    Escaped strings should not be quotted.
    
    While here, also rework the way networks are escaped: the previous code
    was generating invalid parameters.
    smortex committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    e848283 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3f09d92 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #869 from puppetlabs/GH-811-reimplement_reverted_PR

    docker_run_flags: Shellescape any provided values
    GSPatton authored Nov 8, 2022
    Configuration menu
    Copy the full SHA
    088cb33 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. (CONT-263) Bumping required puppet version

    Prior to this commit, as part of the codebase hardening project, an
    important piece of update was missed: raising the minimum required
    puppet version to 6.24.0, so that certain command breakdowns could
    occur.
    
    This commit aims to fix that. It can also be considered part of the
    ticket CONT-263 and the final update required before a major release can
    be cut.
    LukasAud committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    17c7668 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #871 from puppetlabs/CONT-263-Required_minimum_ver…

    …sion_bump
    
    (CONT-263) Bumping required puppet version
    jordanbreen28 authored Nov 21, 2022
    Configuration menu
    Copy the full SHA
    f008965 View commit details
    Browse the repository at this point in the history
  3. Release prep v6.0.0

    GitHub Action committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    36f9e29 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #873 from puppetlabs/release-prep

    Release prep v6.0.0
    LukasAud authored Nov 21, 2022
    Configuration menu
    Copy the full SHA
    d8445c6 View commit details
    Browse the repository at this point in the history
Loading