New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCKER_STORAGE_OPTIONS under CentOS 7 #518
Comments
In head you wrote "CentOS 7" but environment is "CentOS 6.7" - is this ok? |
My mistake... The correct environment is CentOS 7.5 |
The module is trying to manage both, |
To clarify my comment above, the default
which calls The module, however, manages both files, so Puppet module fights |
Closing this issue as this issue only happens with older docker versions (ex. 1.13) on EL7 based OSes. |
Describe the Bug
During every agent run, according to template definition, the file /etc/sysconfig/docker-storage is modified introducing some modifications. After service refresh, the file is modified back eliminating comment and white spaces.
During the next agent run the file is being modified again, establishing a loop of configuration change and service restart.
Steps to Reproduce
Steps to reproduce the behavior:
Notice: /Stage[main]/Docker::Service/File[/etc/sysconfig/docker-storage]/content:
--- /etc/sysconfig/docker-storage 2019-08-09 11:19:36.522292463 +0200
+++ /tmp/puppet-file20190809-6870-1uzkg1e 2019-08-09 11:24:50.431992585 +0200
@@ -1 +1,17 @@
-DOCKER_STORAGE_OPTIONS="--storage-driver overlay2 "
+# This file is managed by Puppet and local changes
+# may be overwritten
+
+# This file may be automatically generated by an installation program.
+
+# By default, Docker uses a loopback-mounted sparse file in
+# /var/lib/docker. The loopback makes it slower, and there are some
+# restrictive defaults, such as 100GB max storage.
+
+# If your installation did not set a custom storage for Docker, you
+# may do it below.
+
+# Example: Use a custom pair of raw logical volumes (one for metadata,
+# one for data).
+# DOCKER_STORAGE_OPTIONS = --storage-opt dm.metadatadev=/dev/mylogvol/my-docker-metadata --storage-opt dm.datadev=/dev/mylogvol/my-docker-data
+
+DOCKER_STORAGE_OPTIONS=" --storage-driver overlay2"
Info: Computing checksum on file /etc/sysconfig/docker-storage
Info: /Stage[main]/Docker::Service/File[/etc/sysconfig/docker-storage]: Filebucketed /etc/sysconfig/docker-storage to puppet with sum b207e5a55244479f4a7cc4ac361e1daf
Notice: /Stage[main]/Docker::Service/File[/etc/sysconfig/docker-storage]/content: content changed '{md5}b207e5a55244479f4a7cc4ac361e1daf' to '{md5}a4e00a01b4e7a8011c4d9b7375f6a50d'
Info: /Stage[main]/Docker::Service/File[/etc/sysconfig/docker-storage]: Scheduling refresh of Service[docker]
Notice: /Stage[main]/Docker::Service/Service[docker]: Triggered 'refresh' from 1 event
Environment
The text was updated successfully, but these errors were encountered: