(maint)CLOUD-1768 Fixing incorrect cpuset flag #183 #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this parameter just wrong, or did it change in a recent version? |
MWilsonPuppet
force-pushed
the
cloud-1768-fixing-flag
branch
from
a71bcc8
to
3e7d6b4
Compare
|
@jeefberkey It looks like the flag was deprecated in release V1.8.0 and removed in V1.10.0. |
|
That's old enough for me :) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to resolve issue #183. The wrong flag was being passed to set the cpuset. I was not seeing the original warning that was reported but was seeing that when the cpuset parameter was set the container did not run. However when the flag was changed to the correct one the container started as expected. Also updated spec tests.