Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "start a container with cpuset" acceptance test on ubuntu1404 #236

Merged
merged 1 commit into from
May 24, 2018

Conversation

mihaibuzgau
Copy link
Contributor

On Ubuntu 14.04 creating containers does not spawn new processes, like it does on Ubuntu 16.04

This PR fixes the assert condition for "the Puppet Docker module clean up before each test docker::run should start a container with cpuset parameter set" acceptance test by changing the assert statement from searching for a process that belongs to a newly spawned container to using the "docker inspect" command.

Copy link
Contributor

@davejrt davejrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davejrt
Copy link
Contributor

davejrt commented May 24, 2018

LGTM

@davejrt davejrt merged commit b217060 into puppetlabs:master May 24, 2018
@MWilsonPuppet MWilsonPuppet added this to the V2.0.0 milestone Jul 17, 2018
@Ramesh7 Ramesh7 added the bugfix label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants