New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing value in the --prune parameter for docker stack deploy #407

Merged
merged 2 commits into from Jan 13, 2019

Conversation

Projects
None yet
2 participants
@venushka
Copy link
Contributor

venushka commented Jan 11, 2019

Removing value in the --prune parameter for docker stack deploy as the cli doesn't have a value as per the documentation. (see https://docs.docker.com/engine/reference/commandline/stack_deploy/)

With the existing code, if we use the prune option as follows, the docker stack deploy command fails.

  docker::stack { 'proxy': 
    ensure        => present,
    stack_name    => 'proxy',
    compose_files => '/tmp/proxy-compose.yml',
    prune         => true
  }
@davejrt

This comment has been minimized.

Copy link
Collaborator

davejrt commented Jan 13, 2019

LGTM

@davejrt davejrt merged commit 643b218 into puppetlabs:master Jan 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davejrt davejrt added this to the 3.2.0 milestone Jan 13, 2019

@venushka

This comment has been minimized.

Copy link
Contributor Author

venushka commented Jan 13, 2019

Thanks for merging this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment