New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing underscore characters from local_user variable before using it with stdlib's pw_hash #408

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
2 participants
@venushka
Copy link
Contributor

venushka commented Jan 14, 2019

We have a system user that has an underscore in the name, and trying to setup docker registry auth for that user causes the following error.

Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, pw_hash(): characters in salt must be in the set [a-zA-Z0-9./] at /etc/puppetlabs/code/environments/development/modules/docker/manifests/registry.pp:105:20  at /etc/puppetlabs/code/environments/development/modules/docker/manifests/registry_auth.pp:3 on node

This change removes underscore characters from local_user variable before using it with stdlib's pw_hash which only allows [a-zA-Z0-9./]+

Removing underscore characters from local_user variable before using …
…it with stdlib's pw_hash which only allows [a-zA-Z0-9./]+
@davejrt

This comment has been minimized.

Copy link
Collaborator

davejrt commented Jan 14, 2019

LGTM

@davejrt davejrt merged commit 4a41e9f into puppetlabs:master Jan 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davejrt davejrt added this to the 3.2.1 milestone Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment