Fix error does not show when image:tag does not exists (#552) #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelcarv
changed the title
|
Hey @rafaelcarv |
florindragos
approved these changes
Nov 27, 2019
|
what was the point in leaving the second |
| returns => ['0', '2'], | ||
| require => File[$update_docker_image_path], | ||
| provider => $exec_provider, | ||
| logoutput => true, |
There was a problem hiding this comment.
This probably needs the refreshonly metaparam set to true to ensure noop behaviour works as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an exec resource instead of the onlyif will execute the script in a resource, not in a condition. This will make an error to be shown when an image:tag does not exists, not just not making an echo to be shown when the script fails.
Doing the execution of the script this way will be easier to track when a image:tag has a typo or was not created yet.