Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-9696) remove docker_home_dirs fact #613

Merged
merged 1 commit into from
May 20, 2020

Conversation

carabasdaniel
Copy link
Contributor

enumerating existing users is insecure and resource consuming
user with non-standard home needs to path it explicitly when creating docker::registry resource

Rebased changes from PR: #517

enumerating existing users is insecure and resource consuming
user with non-standard home needs to path it explicitly when creating docker::registry resource
@carabasdaniel carabasdaniel requested a review from a team as a code owner May 20, 2020 10:10
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #613 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
- Coverage   28.19%   27.94%   -0.26%     
==========================================
  Files          19       19              
  Lines         688      680       -8     
==========================================
- Hits          194      190       -4     
+ Misses        494      490       -4     
Impacted Files Coverage Δ
lib/facter/docker.rb 83.07% <ø> (+3.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f9adee...86af7e3. Read the comment docs.

@sheenaajay sheenaajay merged commit 89cd9c1 into puppetlabs:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants