Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all 3.x docker-compose minor versions #620

Conversation

runejuhl
Copy link
Contributor

@runejuhl runejuhl commented Jun 2, 2020

No major changes affecting this module compared to the previous max
compatibility with docker-compose 3.6; see
https://docs.docker.com/compose/compose-file/compose-versioning/#version-37

Fixes #575

No major changes affecting this module compared to the previous max
compatibility with docker-compose 3.6; see
https://docs.docker.com/compose/compose-file/compose-versioning/#version-37

Fixes puppetlabs#575
@runejuhl runejuhl requested a review from a team as a code owner June 2, 2020 18:36
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2020

Codecov Report

Merging #620 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #620   +/-   ##
=======================================
  Coverage   27.94%   27.94%           
=======================================
  Files          19       19           
  Lines         680      680           
=======================================
  Hits          190      190           
  Misses        490      490           
Impacted Files Coverage Δ
lib/puppet/provider/docker_compose/ruby.rb 20.63% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fe049f...554aa09. Read the comment docs.

@daianamezdrea
Copy link
Contributor

Hi @runejuhl, this LGTM and the tests are green, thank you for your contribution! Cheers!

@daianamezdrea daianamezdrea merged commit 9c3d7a8 into puppetlabs:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported docker compose file syntax version "3.7"
4 participants