Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #584: Deal with Arrays for the net list #647

Merged
merged 2 commits into from Aug 11, 2020

Conversation

MG2R
Copy link
Contributor

@MG2R MG2R commented Aug 6, 2020

Might need tests too, but it seems like the entire function is testless.

@MG2R MG2R requested a review from a team as a code owner August 6, 2020 18:16
@puppet-community-rangefinder
Copy link

docker_run_flags is a function

Breaking changes to this file WILL impact these 1 modules (exact match):
Breaking changes to this file MAY impact these 6 modules (near match):

This module is declared in 7 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2020

Codecov Report

Merging #647 into main will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
- Coverage   25.71%   25.64%   -0.07%     
==========================================
  Files          20       20              
  Lines         739      741       +2     
==========================================
  Hits          190      190              
- Misses        549      551       +2     
Impacted Files Coverage Δ
lib/puppet/parser/functions/docker_run_flags.rb 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 360cdb5...2f5689d. Read the comment docs.

@adrianiurca
Copy link
Contributor

Hi @MG2R , thank you for your contribution. Can you rebase please and solve the merge conflicts?

Kind regards,
@adrianiurca

@MG2R
Copy link
Contributor Author

MG2R commented Aug 10, 2020

Done, I incorporated the shellescape in my joined array as well.

@adrianiurca adrianiurca merged commit 391e9e6 into puppetlabs:main Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants