Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MODULES-10898] Disable forced docker service restart for RedHat 7 and docker server 1.13 #730

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

carabasdaniel
Copy link
Contributor

@carabasdaniel carabasdaniel commented Mar 3, 2021

Workaround for #518 by disabling forced service restart on storage configuration change for RedHat 7 and Docker server version 1.13+

@puppet-community-rangefinder
Copy link

docker::service is a class

that may have no external impact to Forge modules.

This module is declared in 6 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@carabasdaniel carabasdaniel marked this pull request as ready for review March 3, 2021 09:40
@carabasdaniel carabasdaniel requested a review from a team as a code owner March 3, 2021 09:40
@carabasdaniel carabasdaniel changed the title Disable forced docker service restart for RedHat 7 and docker server 1.13 [MODULES-10898] Disable forced docker service restart for RedHat 7 and docker server 1.13 Mar 3, 2021
@codecov-io
Copy link

Codecov Report

Merging #730 (f8eb122) into main (284a7d3) will decrease coverage by 2.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
- Coverage   23.42%   21.39%   -2.03%     
==========================================
  Files          20       20              
  Lines         760      832      +72     
==========================================
  Hits          178      178              
- Misses        582      654      +72     
Impacted Files Coverage Δ
lib/puppet/parser/functions/docker_run_flags.rb 0.00% <0.00%> (ø)
...b/puppet/parser/functions/docker_params_changed.rb
lib/puppet/functions/docker_params_changed.rb 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 284a7d3...f8eb122. Read the comment docs.

@carabasdaniel carabasdaniel changed the base branch from main to release March 4, 2021 09:51
@pmcmaw pmcmaw merged commit 192ea47 into puppetlabs:release Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants