Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some legacy facts #802

Merged
merged 1 commit into from
May 5, 2022
Merged

remove some legacy facts #802

merged 1 commit into from
May 5, 2022

Conversation

traylenator
Copy link
Contributor

The params.pp still had some legacy facts for os.

The params.pp still had some legacy facts for os.
@traylenator traylenator requested a review from a team as a code owner March 10, 2022 12:35
@puppet-community-rangefinder
Copy link

docker::params is a class

that may have no external impact to Forge modules.

This module is declared in 6 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@traylenator
Copy link
Contributor Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

CLA has been signed on behalf of all CERN IT department.

@chelnak chelnak closed this May 4, 2022
@chelnak chelnak reopened this May 4, 2022
@puppet-community-rangefinder
Copy link

docker::params is a class

that may have no external impact to Forge modules.

This module is declared in 6 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@chelnak
Copy link
Contributor

chelnak commented May 4, 2022

Re-kicking the tests...

@chelnak chelnak closed this May 5, 2022
@chelnak chelnak reopened this May 5, 2022
@puppet-community-rangefinder
Copy link

docker::params is a class

that may have no external impact to Forge modules.

This module is declared in 6 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@chelnak chelnak merged commit 8d3b190 into puppetlabs:main May 5, 2022
@chelnak chelnak added the bugfix label May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants