Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONT-568 : Adding deferred function for password #918

Merged
merged 1 commit into from Jul 19, 2023
Merged

CONT-568 : Adding deferred function for password #918

merged 1 commit into from Jul 19, 2023

Conversation

malikparvez
Copy link
Member

Adding deferred function for password

@malikparvez malikparvez requested a review from a team as a code owner May 23, 2023 16:02
@puppet-community-rangefinder
Copy link

docker::deferred_password is a function

that may have no external impact to Forge modules.

This module is declared in 6 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@malikparvez malikparvez self-assigned this May 23, 2023
Ramesh7
Ramesh7 reviewed May 23, 2023
View reviewed changes
manifests/registry.pp Outdated Show resolved Hide resolved
@Ramesh7 Ramesh7 force-pushed the CONT-568_deferred branch 2 times, most recently from 49e6eb4 to c2fac17 Compare May 31, 2023 05:25
@jordanbreen28
Copy link
Contributor

Looks good.
Could you clean up the commits abit?

GSPatton
GSPatton approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@GSPatton GSPatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@GSPatton GSPatton merged commit 5453ccc into main Jul 19, 2023
24 checks passed
@GSPatton GSPatton deleted the CONT-568_deferred branch July 19, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ramesh7 Ramesh7 Ramesh7 left review comments

@jordanbreen28 jordanbreen28 jordanbreen28 left review comments

@GSPatton GSPatton GSPatton approved these changes

Assignees

@malikparvez malikparvez

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@malikparvez @jordanbreen28 @Ramesh7 @GSPatton