-
Notifications
You must be signed in to change notification settings - Fork 27
Comparing changes
Open a pull request
base repository: puppetlabs/puppetlabs-dsc_lite
base: 0.5.0
head repository: puppetlabs/puppetlabs-dsc_lite
compare: 0.6.0
- 18 commits
- 31 files changed
- 8 contributors
Commits on Jul 10, 2018
-
Merge pull request #64 from RandomNoun7/release
Mergeback for 0.5.0
Configuration menu - View commit details
-
Copy full SHA for 022a552 - Browse repository at this point
Copy the full SHA 022a552View commit details
Commits on Jul 12, 2018
-
(MODULES-7437) Use absolute link in README
Previously the trade offs link was relative to the README, however, on the Forge this does not work. This commit updates the link to be absolute.
Configuration menu - View commit details
-
Copy full SHA for cf822ce - Browse repository at this point
Copy the full SHA cf822ceView commit details -
Merge pull request #65 from glennsarti/glennsarti-patch-1
(MODULES-7437) Use absolute link in README
Configuration menu - View commit details
-
Copy full SHA for cd41f6c - Browse repository at this point
Copy the full SHA cd41f6cView commit details -
(MODULES-6474) add testmode switcher to Gemfile and .sync.yml
Erick Banks committedJul 12, 2018 Configuration menu - View commit details
-
Copy full SHA for 91f01c0 - Browse repository at this point
Copy the full SHA 91f01c0View commit details
Commits on Jul 13, 2018
-
(MODULES-6474) refactor tests to use execute_manifest
Converted "on(agent...)" tests to use testmode switcher method "execute_manifest()" method Removed now unnecessary "windows_agents.each" guards around the new "execute manifest" calls
Erick Banks committedJul 13, 2018 Configuration menu - View commit details
-
Copy full SHA for 9c67bb4 - Browse repository at this point
Copy the full SHA 9c67bb4View commit details -
Merge pull request #67 from ThoughtCrhyme/MODULES-6474
Modules 6474
Configuration menu - View commit details
-
Copy full SHA for f6c06e7 - Browse repository at this point
Copy the full SHA f6c06e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fd3e5d - Browse repository at this point
Copy the full SHA 0fd3e5dView commit details
Commits on Jul 17, 2018
-
Merge pull request #68 from RandomNoun7/readme_edits
(MAINT) Update Readme
Erick Banks authoredJul 17, 2018 Configuration menu - View commit details
-
Copy full SHA for 4615b9a - Browse repository at this point
Copy the full SHA 4615b9aView commit details
Commits on Jul 18, 2018
-
(MODULES-7400) PDK Convert dsc_lite
This commit converts the module for use by the Puppet Development Kit (PDK). Note that the rubocop rules are disabled and the violations will be fixed in later commits.
Configuration menu - View commit details
-
Copy full SHA for abe3e2e - Browse repository at this point
Copy the full SHA abe3e2eView commit details -
(MODULES-7178) Report types dynamically
- Prior to this commit, all types would report the `dsc` type as their identity. This is problematic for the sake of reporting as every type of resource is grouped together under `dsc`, rather than the specific `resource_name` modeled in a manifest. This new approach allows for types to report under something more useful that indicates the original DSC resource type specified in the resource_name attribute. For instance, given a manifest with the following resources: dsc { 'sample_file': resource_name => 'File', module => 'PSDesiredStateConfiguration', properties => { ensure => 'present', contents => 'hello', destinationpath => 'c:\\test.txt', } } dsc { 'lmhosts': resource_name => 'Service', module => 'PSDesiredStateConfiguration', properties => { name => 'lmhosts', ensure => 'present', state => 'running', } } The report now shows: * Dsc_lite_file[sample_file] Unchanged * Dsc_lite_service[lmhosts] Unchanged Instead of what it previously reported: * Dsc[sample_file] Unchanged * Dsc[lmhosts] Unchanged - Selection of the PowerShell code was previously determined by type, but given it has changed to being specified as :Dsc_lite_XXXX, its not as easy to do that anymore. Instead, add a simple boolean property to the generic dsc wrapper that may be checked instead. - Note that parameter validation for `module`, `resource_name` and properties does not currently work, but will be fixed in another ticket by adding a global validator. The `type` method performs some additional guarding around usage of the `resource_name` parameter for 2 reasons: * It's unclear if the parser or other logic in Puppet uses the type name without the resource being instantiated fully with values from a manifest * Due to the incorrect validation, the PE console errors with the following message when `resource_name` is left unspecified: undefined method `value` for nil:NilClassConfiguration menu - View commit details
-
Copy full SHA for 87e841e - Browse repository at this point
Copy the full SHA 87e841eView commit details -
Merge pull request #69 from Iristyle/MODULES-7178-report-generic-dsc-…
…resources-with-specific-types (MODULES-7178) Report types dynamically
Configuration menu - View commit details
-
Copy full SHA for 8344792 - Browse repository at this point
Copy the full SHA 8344792View commit details
Commits on Jul 19, 2018
-
Merge pull request #70 from glennsarti/try-pdk
(MODULES-7400) PDK Convert dsc_lite
James Pogran authoredJul 19, 2018 Configuration menu - View commit details
-
Copy full SHA for 41dab1c - Browse repository at this point
Copy the full SHA 41dab1cView commit details
Commits on Jul 20, 2018
-
(MODULES-7485) Fix validation for required parameters
This commit uses global type validation to require the `module`, `resources_name`, and `properties`, instead of `isrequired`. `isrequired` does not work ( see https://projects.puppetlabs.com/issues/4049 / https://tickets.puppetlabs.com/browse/PUP-1591 ) This also removes the tests for situations where `resource_name` is not supplied, as the prior commit adds validation to ensure `resource_name` is supplied. The tests would always fail because `resource_name` is now required.
Configuration menu - View commit details
-
Copy full SHA for 9945acf - Browse repository at this point
Copy the full SHA 9945acfView commit details
Commits on Jul 23, 2018
-
Merge pull request #71 from jpogran/MODULES-7485-fix-validation-for-r…
…equired-parameters (MODULES-7485) Fix validation for required parameters
Configuration menu - View commit details
-
Copy full SHA for 2b3e950 - Browse repository at this point
Copy the full SHA 2b3e950View commit details
Commits on Jul 30, 2018
-
(MODULES-7554) Fix crash on Puppet 4 / WMF < 5
- 914d934 introduced a new feature for dsc_lite. In situations where the proper WMF5 version was not available, a warning would be generated using the Puppet.warn_once helper. However, it was not realized that Puppet 4 and Puppet 5 have different numbers of arguments that can be passed to warn_once, and that only Puppet 5 supported changing warning to error. That change was introduced in puppetlabs/puppet@3d82337 - Calling a Ruby method with too many arguments causes a Ruby crash and results in a completely terminated Puppet run that produces no report for the master. In other words, this is a completely catastrophic failure case. - Resolve this problem by checking the arity of the Puppet.warn_once call to send the right number of arguments on Puppet 4. The concession was made to vary the message type on Puppet 4 (warning) vs Puppet 5 (error), because the alternative solution did not preserve the warn_once style behavior. Instead, it would have produced an error for every single dsc_lite resource, which was far less desirable.
Configuration menu - View commit details
-
Copy full SHA for 8807d01 - Browse repository at this point
Copy the full SHA 8807d01View commit details
Commits on Aug 1, 2018
-
Merge pull request #72 from Iristyle/MODULES-7554-fix-crash-on-Puppet…
…-4-less-than-WMF5 (MODULES-7554) Fix crash on Puppet 4 / WMF < 5
James Pogran authoredAug 1, 2018 Configuration menu - View commit details
-
Copy full SHA for 3da68fe - Browse repository at this point
Copy the full SHA 3da68feView commit details
Commits on Aug 2, 2018
-
(MODULES-7574) Release prep for 0.6.0
This commit updates the changelog and metadata in preparation for the release of the module at 0.6.0
Configuration menu - View commit details
-
Copy full SHA for 1b3027d - Browse repository at this point
Copy the full SHA 1b3027dView commit details -
Merge pull request #73 from michaeltlombardi/ticket/release/MODULES-7…
…574-release-prep-060 (MODULES-7574) Release prep for 0.6.0
Configuration menu - View commit details
-
Copy full SHA for 2b16dfa - Browse repository at this point
Copy the full SHA 2b16dfaView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0.5.0...0.6.0