(WIN-280) add skip() unless pattern to tests #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to facilitate more complete test output from our unit tests.
michaeltlombardi
previously approved these changes
Mar 15, 2019
RandomNoun7
suggested changes
Mar 15, 2019
| @@ -384,6 +411,7 @@ def close_stream(stream, style = :inprocess) | |||
| end | |||
|
|
|||
| it "should execute code with a try/catch, receiving the output of Write-Error" do | |||
| skip ('Not on Windows platform') unless Puppet::Util::Platform.windows? | |||
There was a problem hiding this comment.
The indentation level here seems to be different than the rest of them.
| @@ -416,7 +445,8 @@ def close_stream(stream, style = :inprocess) | |||
| end | |||
|
|
|||
| it "should be able to execute the code in a catch block when using try/catch" do | |||
| result = manager.execute(<<-CODE | |||
| skip ('Not on Windows platform') unless Puppet::Util::Platform.windows? | |||
| result = manager.execute(<<-CODE | |||
There was a problem hiding this comment.
Same with these two lines. Indentation level is causing a line diff at 449 where there's not really a difference.
RandomNoun7
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to facilitate more complete test output from our unit tests.