(MODULES-9800) Fix Lib Environment Variable Check #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomNoun7
changed the title
RandomNoun7
force-pushed
the
MODULES-9800-fix-lib-paths-check
branch
from
7c152e8
to
51c6340
Compare
Prior to this commit, the function that checks for valid paths in the `lib` environment variable was broken. It would return true, and raise an error if any value at all was assigned to that variable. This commit fixes the behavior of that function and unit tests it to prevent regressions.
RandomNoun7
force-pushed
the
MODULES-9800-fix-lib-paths-check
branch
from
51c6340
to
27b86ae
Compare
|
|
michaeltlombardi
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the function that checks for valid paths in the
libenvironment variable was broken. It would return true, and raisean error if any value at all was assigned to that variable.
This commit fixes the behavior of that function and unit tests it to
prevent regressions.