(MODULES-10471) Allow namevar to have special chars #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the namevar in the dsc type allowed a subset of characters. This was not a functional limit and did not need to be in place. This commit removes this restriction and ensure the name is a string. This commit also fixes the spec tests for the `resource_name` as they were only testing the `name` parameter.
|
Please note that I have not run this through any acceptance testing. Does this repo have litmus enabled? |
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
=======================================
Coverage 56.72% 56.72%
=======================================
Files 7 7
Lines 275 275
=======================================
Hits 156 156
Misses 119 119
Continue to review full report at Codecov.
|
|
Thanks @jarretlavallee for submitting the PR. Yes, its litmus ported. But will run a release checks on all platforms too. Thank you. |
sheenaajay
reviewed
Feb 14, 2020
|
|
sheenaajay
previously approved these changes
Feb 14, 2020
Prior to this commit, the resource_name spec was not specific to the name of the resource. This commit updates the regex to check for the name of the resource. Co-Authored-By: sheenaajay <sheena@puppet.com>
|
Thanks @sheenaajay. I merged the suggested change. |
sheenaajay
approved these changes
Feb 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the namevar in the dsc type allowed a subset of
characters. This was not a functional limit and did not need to be in
place. This PR removes this restriction and ensure the name is a
string.
This PR also fixes the spec tests for the
resource_nameasthey were only testing the
nameparameter. This just updates it to test theresource_nameand removes the spec tests for the special character limitations.