(CAT-1869) - Add configurable dsc_timeout param for dsc type #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
force-pushed
the
cat-1869-add_configurable_timeout
branch
9 times, most recently
from
ade0932
to
6e32015
Compare
Prior to this commit, we set a default timeout of 20 minutes for the dsc
type, and this was not configurable.
This change adds a new "dsc_timeout" param to the dsc type, which
accepts an integer value for the number of seconds execution should wait
before exiting.
Users can now configure this timeout through their manifests, same as
you would with any other property see below:
```
dsc { "Running Script":
resource_name => 'Script',
module => 'PSDesiredStateConfiguration',
dsc_timeout => 10,
properties => {
getscript => 'Start-Sleep -Seconds 5',
testscript => '$false',
setscript => 'Start-Sleep -Seconds 5',
},
}
```
jordanbreen28
force-pushed
the
cat-1869-add_configurable_timeout
branch
from
6e32015
to
fad6643
Compare
pmcmaw
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we set a default timeout of 20 minutes for the dsc type, and this was not configurable.
This change adds a new "dsc_timeout" param to the dsc type, which accepts an integer value for the number of seconds execution should wait before exiting.
Users can now configure this timeout through their manifests, same as you would with any other property see below: