(Bug) - Fix timeout matcher #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
force-pushed
the
bug-fix_timeout_matcher
branch
5 times, most recently
from
c6427fc
to
c303ed4
Compare
Ths commit fixes the timeout matcher to more accurately match a legitimate dsc timeout. Before, if output was nil for any other reason dsc_lite would assume timeout which is not strictly correct. There is a specific error message returned on dsc timeout which we should strive to match instead. Additionally, moved the logic to only execute for nodes with windows powershell support as we can only pass a timeout to powershell on these nodes.
jordanbreen28
force-pushed
the
bug-fix_timeout_matcher
branch
from
c303ed4
to
a31f0b9
Compare
danadoherty639
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ths commit fixes the timeout matcher to more accurately match a legitimate dsc timeout. Before, if output was nil for any other reason dsc_lite would assume timeout which is not strictly correct. There is a specific error message returned on dsc timeout which we should strive to match instead.
Additionally, moved the logic to only execute for nodes with windows powershell support as we can only pass a timeout to powershell on these nodes, and use the default error output from powershell as it is more concise and does a better job of conveying the message.