(MODULES-7179) Change created to invoked #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomNoun7
force-pushed
the
tickets/master/MODULES-7179-change-created-to-invoked
branch
2 times, most recently
from
327fe57
to
60bb7ec
Compare
RandomNoun7
changed the title
|
@ThoughtCrhyme I think changing the verbage in those two tests will be fine as far as testing the change in this PR, just because if someone does revert to returning 'changed', these tests will definitely fail, and there aren't really any additional useful code paths to worry about. |
ThoughtCrhyme
previously approved these changes
Jul 3, 2018
This commit changes the message that Puppet returns when dsc_lite resources are run from "created" to "invoked". This is because at the moment, when we invoke a dsc_lite resource, Puppet does not know if the resource we want to manage has actually been created, or if in reality it has simply been modified, or even deleted. Changing to invoked is more ambiguous, but accurately reflects the idea that we don't truly know what operation dsc has accomplished for us.
RandomNoun7
force-pushed
the
tickets/master/MODULES-7179-change-created-to-invoked
branch
from
60bb7ec
to
75e0fce
Compare
ThoughtCrhyme
approved these changes
Jul 5, 2018
RandomNoun7
deleted the
tickets/master/MODULES-7179-change-created-to-invoked
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the message that Puppet returns when dsc_lite
resources are run from "created" to "invoked". This is because at the
moment, when we invoke a dsc_lite resource, Puppet does not know if the
resource we want to manage has actually been created, or if in reality
it has simply been modified, or even deleted. Changing to invoked is
more ambiguous, but accurately reflects the idea that we don't truly
know what operation dsc has accomplished for us.