(MODULES-8175) Add safety to new-pscredential helper #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeltlombardi
changed the title
RandomNoun7
previously approved these changes
Dec 7, 2018
Prior to this commit the helper function `new-pscredential` in the template used to invoke DSC resources attempted to cast an incoming value for password to a string. When passed a hashtable, it was unable to extract the password for use and instead set the password as the typename for the object. This happened when the catalog was compiled on a Puppet 5 master to apply to a Puppet 6 agent or when compiled on a Puppet 6 master for a Puppet 5 agent and specifying the password using the sensitive datatype. This problem was introduced in MODULES-8597 when the tags for rich data serialization were changed from `__pcore_type_` and `__pcore_value__` to the shorter `__ptype` and `__pvalue`. After this change, the master and agent both expect different keys for the sensitive data type, which is why this problem only shows when the master and agent are mismatched versions. This commit modifies the `new-pscredential` helper function to include handling for both strings and hashtables, and will extract the password if possible and error loudly if not.
RandomNoun7
approved these changes
Dec 7, 2018
Iristyle
reviewed
Dec 7, 2018
| $password | ||
| ) | ||
|
|
||
| Switch ($password.GetType().FullName) { |
There was a problem hiding this comment.
Hmmmm - I'm a little confused on why we're doing all of this special handling on the PowerShell side instead of just munging the value consistently on the Ruby side?
|
This will be reverted in favor of #92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the helper function
new-pscredentialin the template used to invoke DSC resources attempted to
cast an incoming value for password to a string. When passed
a hashtable, it was unable to extract the password for use
and instead set the password as the typename for the object.
This happened when the catalog was compiled on a Puppet 5
master to apply to a Puppet 6 agent or when compiled on a
Puppet 6 master for a Puppet 5 agent and specifying the
password using the sensitive datatype.
This problem was introduced in MODULES-8597 when the tags
for rich data serialization were changed from
__pcore_type_and
__pcore_value__to the shorter__ptypeand__pvalue.After this change, the master and agent both expect different
keys for the sensitive data type, which is why this problem
only shows when the master and agent are mismatched versions.
This commit modifies the
new-pscredentialhelper functionto include handling for both strings and hashtables, and
will extract the password if possible and error loudly if
not.