From a626cf2dcf24d12ced4d91a15ab64b5494d4ffb2 Mon Sep 17 00:00:00 2001 From: Hunter Haugen Date: Mon, 15 Sep 2014 16:20:09 -0700 Subject: [PATCH] (MODULES-1086) toports is not reqired with jump == REDIRECT From the man page for REDIRECT and --to-ports: "This specifies a destination port or range of ports to use: without this, the destination port is never altered." --- lib/puppet/type/firewall.rb | 7 ------- 1 file changed, 7 deletions(-) diff --git a/lib/puppet/type/firewall.rb b/lib/puppet/type/firewall.rb index 34a5d33a6..66f0f0656 100644 --- a/lib/puppet/type/firewall.rb +++ b/lib/puppet/type/firewall.rb @@ -1090,13 +1090,6 @@ def should_to_s(value) end end - if value(:jump).to_s == "REDIRECT" - unless value(:toports) - self.fail "Parameter jump => REDIRECT missing mandatory toports " \ - "parameter" - end - end - if value(:jump).to_s == "MASQUERADE" unless value(:table).to_s =~ /nat/ self.fail "Parameter jump => MASQUERADE only applies to table => nat"