-
Notifications
You must be signed in to change notification settings - Fork 457
Comparing changes
Open a pull request
base repository: puppetlabs/puppetlabs-firewall
base: v0.0.1
head repository: puppetlabs/puppetlabs-firewall
compare: v0.0.2
- 10 commits
- 9 files changed
- 2 contributors
Commits on Oct 21, 2011
-
(#10163) Cleanup some of the inline documentation and README file to …
…align with general forge usage. * The README.markdown file had a lot of property information that was duplicated in the type itself. The README.markdown file has more info in some cases, I have moved this into the type. * The README.markdown lacked documentation on how to install the module using the forge which meant users accessing it via github would be inclined to download the development version from github instead. * Cleaned up doc string alignments and made it consistent with all types.
Configuration menu - View commit details
-
Copy full SHA for 523ed21 - Browse repository at this point
Copy the full SHA 523ed21View commit details
Commits on Oct 22, 2011
-
Merge pull request #17 from kbarber/ticket/10163-doc_cleanup
(#10163) Cleanup some of the inline documentation and README file to alig
Configuration menu - View commit details
-
Copy full SHA for a869eac - Browse repository at this point
Copy the full SHA a869eacView commit details
Commits on Oct 25, 2011
-
(#10263) Fix tests on Puppet 2.6.x
Due to the lack of Puppet::Test::LogCollector class, tests fail on puppet 2.6.x. Instead of just using the class, I'm testing its existance first and only using it if it exists. Otherwise, I'm going to fall back to 2.6.x methodology. This seems to make tests work on 2.6.7 (and up) and 2.7.1 (and up) which is sufficient for now.
Configuration menu - View commit details
-
Copy full SHA for 85ab45f - Browse repository at this point
Copy the full SHA 85ab45fView commit details -
Merge pull request #20 from kbarber/ticket/10263-tests_fail_on_puppet…
…-2.6.x (#10263) Fix tests on Puppet 2.6.x
Configuration menu - View commit details
-
Copy full SHA for 5abf102 - Browse repository at this point
Copy the full SHA 5abf102View commit details
Commits on Oct 26, 2011
-
(#10002) Change to dport and sport to handle ranges, and fix handling…
… of name to port. We hadn't been allowing ranges of the kind 22:1000 for ranges. This patch fixes that. Thanks to Jason Hancock for finding this issue and providing a sample patch. Instead of using colon though, it was decided we would use a hyphen to specify a range as its more agnostic. This patch does the filtering for both writing the rule and reading the rule. Also - the way we were doing name to port conversion had been broken. I found this out while fixing the ranges, and have now fixed it and added tests.
Configuration menu - View commit details
-
Copy full SHA for 3991b76 - Browse repository at this point
Copy the full SHA 3991b76View commit details -
Merge pull request #21 from kbarber/ticket/10002-range_of_ports
(#10002) Change to dport and sport to handle ranges, and fix handling of
Configuration menu - View commit details
-
Copy full SHA for 766fdcc - Browse repository at this point
Copy the full SHA 766fdccView commit details -
(#10295) Work around bug #4248 whereby the puppet/util paths are not …
…being loaded correctly on the puppetmaster This patch suggested by Dan Carley will work-around the puppet/util error specified in bug #4248 by loading relative paths instead. This also fixes the load errors related to running the resource in a standalone puppet case as well. If the load fails for some reason, we fall back to the normal load behaviour. This order is important as we want to load libraries before sync in case the user has disabled pluginsync in the meantime. This will ensure we attempt to get the latest copy, but have a fall back just in case. I believe this fix will need to be applied for some time to support older Puppet versions. I've updated the documentation to provide more thorough instructions for cases where people are using environments, and to tell people to pluginsync on the master and potentially restart their puppetmaster first just in case.
Configuration menu - View commit details
-
Copy full SHA for f3a7e0c - Browse repository at this point
Copy the full SHA f3a7e0cView commit details -
Merge pull request #22 from kbarber/ticket/10295-util_loader
(#10295) Work around bug #4248 whereby the puppet/util paths are not bein
Configuration menu - View commit details
-
Copy full SHA for 062b0f0 - Browse repository at this point
Copy the full SHA 062b0f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f3adaa - Browse repository at this point
Copy the full SHA 5f3adaaView commit details -
Merge pull request #23 from kbarber/ticket/10303-release_0.0.2
(#10303) Release 0.0.2 - CHANGELOG and Modulefile update
Configuration menu - View commit details
-
Copy full SHA for 05c94df - Browse repository at this point
Copy the full SHA 05c94dfView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.0.1...v0.0.2