Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-firewall
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.5.0
Choose a base ref
...
head repository: puppetlabs/puppetlabs-firewall
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.6.0
Choose a head ref
  • 16 commits
  • 53 files changed
  • 7 contributors

Commits on Jul 28, 2020

  1. Merge pull request #932 from puppetlabs/release 

    Release prep version 2.5.0
    @adrianiurca
    adrianiurca authored Jul 28, 2020
    Configuration menu
    Copy the full SHA
    71a1773 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2020

  1. (IAC-973) - Update travis/appveyor to run on new default branch main

    David Swan committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    b61911d View commit details
    Browse the repository at this point in the history

  2. Merge pull request #933 from puppetlabs/pdksync_IAC-973 

    pdksync - (IAC-973) - Update travis/appveyor to run on new default branch main
    @adrianiurca
    adrianiurca authored Aug 4, 2020
    Configuration menu
    Copy the full SHA
    705e0b5 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2020

  1. Fix problem with parsing rules without quotes

    Łukasz Czapliński committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    5386e8f View commit details
    Browse the repository at this point in the history

  2. (IAC-1025) Fix spec test helper method 

    Tests failing on RHEL systems as the `install_iptables` method
always assumed it was running against Debian / Ubuntu.
    Ciaran McCrisken committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    a521da2 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2020

  1. Merge pull request #938 from sanfrancrisko/fix/spec_helper_method 

    (IAC-1025) Fix spec test helper method
    @david22swan
    david22swan authored Aug 6, 2020
    Configuration menu
    Copy the full SHA
    0fae798 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2020

  1. Merge pull request #937 from operasoftware-osp/provider-regression 

    Fix problem with parsing rules without quotes
    @adrianiurca
    adrianiurca authored Aug 10, 2020
    Configuration menu
    Copy the full SHA
    c494c53 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. (IAC-987) - Removal of inappropriate terminology

    David Swan committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    2b29e12 View commit details
    Browse the repository at this point in the history

  2. (maint) - Removal of legacy nodesets

    David Swan committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    d51a6e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2020

  1. Merge pull request #942 from david22swan/IAC-987 

    (IAC-987) - Removal of inappropriate terminology
    @adrianiurca
    adrianiurca authored Sep 15, 2020
    Configuration menu
    Copy the full SHA
    a90b565 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Resolve simple puppet-lint items

    @jcpunk
    jcpunk committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    16bc4f8 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Fix extra quotes in firewall string matching 

    As reported by Steve Traylon[1] and @patricknelson[2], the munging adds extra quotes to the string.
This breaks the string matching in iptables, as it looks for literal single quotes in the match.

Removing the munging fixes this.

[1] https://tickets.puppetlabs.com/browse/MODULES-3454?focusedCommentId=686988&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-686988
[2] 3655c6b#diff-379160b60a9bdf297b92a51d20efd8c3R1426
    @IBBoard
    IBBoard authored Sep 23, 2020
    Configuration menu
    Copy the full SHA
    739f1e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2020

  1. Fix fixture tests 

    ARGS_TO_HASH was correct (unquoted) but HASH_TO_ARGS
contained the rogue single quotes
    @IBBoard
    IBBoard authored Sep 26, 2020
    Configuration menu
    Copy the full SHA
    9c974c0 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Merge pull request #944 from IBBoard/patch-1 

    Fix extra quotes in firewall string matching
    @adrianiurca
    adrianiurca authored Oct 1, 2020
    Configuration menu
    Copy the full SHA
    7bfa339 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #943 from jcpunk/puppet-lint 

    Resolve puppet-lint notices
    @adrianiurca
    adrianiurca authored Oct 1, 2020
    Configuration menu
    Copy the full SHA
    42bf75f View commit details
    Browse the repository at this point in the history

  3. Release Version 2.6.0

    David Swan committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    fb32fd5 View commit details
    Browse the repository at this point in the history
Loading