-
Notifications
You must be signed in to change notification settings - Fork 457
Comparing changes
Open a pull request
base repository: puppetlabs/puppetlabs-firewall
base: v4.0.0
head repository: puppetlabs/puppetlabs-firewall
compare: v4.0.1
- 9 commits
- 14 files changed
- 5 contributors
Commits on Dec 5, 2022
-
support --nflog-size as replacement for --nflog-range
--nflog-range was deprecated way back in 2016. https://git.netfilter.org/iptables/commit/?h=v1.6.1&id=7070b1f3c88a0c3d4e315c00cca61f05b0fbc882
Configuration menu - View commit details
-
Copy full SHA for c8b9a79 - Browse repository at this point
Copy the full SHA c8b9a79View commit details
Commits on Dec 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e536564 - Browse repository at this point
Copy the full SHA e536564View commit details -
package "iptables" has been replaced by "iptables-nft" on EL9
There are some pointers given by dnf about "iptables", but these confuse Puppet into aborting with the error message: ```console Error: /Stage[main]/Firewall::Linux/Package[iptables]: Could not evaluate: no implicit conversion of Array into Hash ``` Fedora had a similar patch in commit 486e4b5 which I think fixed the bug https://tickets.puppetlabs.com/browse/MODULES-11147 but the same issue rared its head here on AlmaLinux 9.0. The RPM for iptables-legacy states: > This package contains the legacy tools which are obsoleted by > nft-variants in iptables-nft package for backwards compatibility reasons. > If you need to set up firewalls and/or IP masquerading, you should not install > this package but either nftables or iptables-nft instead.
Configuration menu - View commit details
-
Copy full SHA for 371cbfe - Browse repository at this point
Copy the full SHA 371cbfeView commit details -
Merge pull request #1085 from kjetilho/fix/iptables-el9
package "iptables" has been replaced by "iptables-nft" on EL9
Configuration menu - View commit details
-
Copy full SHA for e7efae5 - Browse repository at this point
Copy the full SHA e7efae5View commit details -
(1093) - Fix unresolved fact error
Prior to this commit, work was carried out on this module to update all instances of the now deprecated Facter::Util::Resolution, and replace all with its newer and supported counterpart Facter::Core::Execution. However, these do not behave exactly the same. Facter::Util::Resolution initially ran a which to locate the binary before executing, preventing any errors from occuring. The newer Facter::Core::Execution method did not do this, instead it attempted to execut> This commit aims to introduce an "on_fail:false" flag to each execute statement, so that a failed execute will return false (boolean) as oppose to an error, which can then be used for further logic.
Configuration menu - View commit details
-
Copy full SHA for 14c1371 - Browse repository at this point
Copy the full SHA 14c1371View commit details -
Merge pull request #1094 from puppetlabs/1093-fix_unresolved_fact_error
(1093) - Fix unresolved fact error
Configuration menu - View commit details
-
Copy full SHA for ad7de8e - Browse repository at this point
Copy the full SHA ad7de8eView commit details -
(GH-1097) Bumping back required puppet version (#1098)
Prior to this commit, due to a mistake, there was a reversion to the previously implemented bump to minimum required puppet version, which was part of the CVE update. This commit aims to address issue 1097 in Github which brings to light the need for this puppet bump to be restored to 6.24
Configuration menu - View commit details
-
Copy full SHA for f0bde88 - Browse repository at this point
Copy the full SHA f0bde88View commit details -
GitHub Action committed
Dec 6, 2022 Configuration menu - View commit details
-
Copy full SHA for 70ac55a - Browse repository at this point
Copy the full SHA 70ac55aView commit details
Commits on Dec 7, 2022
-
Merge pull request #1099 from puppetlabs/release-prep
Release prep v4.0.1
Configuration menu - View commit details
-
Copy full SHA for 5f7ef1f - Browse repository at this point
Copy the full SHA 5f7ef1fView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v4.0.0...v4.0.1