Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-firewall
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.0.0
Choose a base ref
...
head repository: puppetlabs/puppetlabs-firewall
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.0.1
Choose a head ref
  • 9 commits
  • 14 files changed
  • 5 contributors

Commits on Dec 5, 2022

  1. Configuration menu
    Copy the full SHA
    c8b9a79 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. Configuration menu
    Copy the full SHA
    e536564 View commit details
    Browse the repository at this point in the history
  2. package "iptables" has been replaced by "iptables-nft" on EL9

    There are some pointers given by dnf about "iptables", but these confuse
    Puppet into aborting with the error message:
    
    ```console
    Error: /Stage[main]/Firewall::Linux/Package[iptables]: Could not evaluate: no implicit conversion of Array into Hash
    ```
    
    Fedora had a similar patch in commit 486e4b5 which I think
    fixed the bug https://tickets.puppetlabs.com/browse/MODULES-11147 but
    the same issue rared its head here on AlmaLinux 9.0.
    
    The RPM for iptables-legacy states:
    
    > This package contains the legacy tools which are obsoleted by
    > nft-variants in iptables-nft package for backwards compatibility reasons.
    > If you need to set up firewalls and/or IP masquerading, you should not install
    > this package but either nftables or iptables-nft instead.
    kjetilho committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    371cbfe View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1085 from kjetilho/fix/iptables-el9

    package "iptables" has been replaced by "iptables-nft" on EL9
    jordanbreen28 authored Dec 6, 2022
    Configuration menu
    Copy the full SHA
    e7efae5 View commit details
    Browse the repository at this point in the history
  4. (1093) - Fix unresolved fact error

    Prior to this commit, work was carried out on this module to update all instances of the now deprecated Facter::Util::Resolution, and replace all with its newer and supported counterpart Facter::Core::Execution.
    However, these do not behave exactly the same. Facter::Util::Resolution initially ran a which to locate the binary before executing, preventing any errors from occuring. The newer Facter::Core::Execution method did not do this, instead it attempted to execut>
    
    This commit aims to introduce an "on_fail:false" flag to each execute statement, so that a failed execute will return false (boolean) as oppose to an error, which can then be used for further logic.
    jordanbreen28 committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    14c1371 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1094 from puppetlabs/1093-fix_unresolved_fact_error

    (1093) - Fix unresolved fact error
    LukasAud authored Dec 6, 2022
    Configuration menu
    Copy the full SHA
    ad7de8e View commit details
    Browse the repository at this point in the history
  6. (GH-1097) Bumping back required puppet version (#1098)

    Prior to this commit, due to a mistake, there was a reversion to the
    previously implemented bump to minimum required puppet version, which
    was part of the CVE update.
    
    This commit aims to address issue 1097 in Github which brings to light
    the need for this puppet bump to be restored to 6.24
    LukasAud authored Dec 6, 2022
    Configuration menu
    Copy the full SHA
    f0bde88 View commit details
    Browse the repository at this point in the history
  7. Release prep v4.0.1

    GitHub Action committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    70ac55a View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Merge pull request #1099 from puppetlabs/release-prep

    Release prep v4.0.1
    jordanbreen28 authored Dec 7, 2022
    Configuration menu
    Copy the full SHA
    5f7ef1f View commit details
    Browse the repository at this point in the history
Loading