2 changes: 0 additions & 2 deletions manifests/params.pp
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
$service_name = 'iptables-persistent'
$package_name = 'iptables-persistent'
}

}
'Ubuntu': {
if versioncmp($::operatingsystemrelease, '14.10') >= 0 {
Expand All @@ -67,7 +66,6 @@
$service_name = 'iptables-persistent'
$package_name = 'iptables-persistent'
}

}
default: {
$service_name = 'iptables-persistent'
Expand Down
6 changes: 3 additions & 3 deletions metadata.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "puppetlabs-firewall",
"version": "2.5.0",
"version": "2.6.0",
"author": "puppetlabs",
"summary": "Manages Firewalls such as iptables",
"license": "Apache-2.0",
Expand Down Expand Up @@ -78,7 +78,7 @@
"version_requirement": ">= 5.5.10 < 7.0.0"
}
],
"template-url": "https://github.com/puppetlabs/pdk-templates#master",
"template-ref": "heads/master-0-g88b05c7",
"template-url": "https://github.com/puppetlabs/pdk-templates#main",
"template-ref": "heads/main-0-g88b05c7",
"pdk-version": "1.17.0"
}
10 changes: 0 additions & 10 deletions spec/acceptance/nodesets/centos-7-x64.yml

This file was deleted.

10 changes: 0 additions & 10 deletions spec/acceptance/nodesets/debian-8-x64.yml

This file was deleted.

10 changes: 0 additions & 10 deletions spec/acceptance/nodesets/default.yml

This file was deleted.

12 changes: 0 additions & 12 deletions spec/acceptance/nodesets/docker/centos-7.yml

This file was deleted.

11 changes: 0 additions & 11 deletions spec/acceptance/nodesets/docker/debian-8.yml

This file was deleted.

12 changes: 0 additions & 12 deletions spec/acceptance/nodesets/docker/ubuntu-14.04.yml

This file was deleted.

29 changes: 0 additions & 29 deletions spec/acceptance/nodesets/new/aio/debian-8-64mda.yml

This file was deleted.

28 changes: 0 additions & 28 deletions spec/acceptance/nodesets/new/aio/redhat-6-64mda.yml

This file was deleted.

28 changes: 0 additions & 28 deletions spec/acceptance/nodesets/new/aio/redhat-7-64mda.yml

This file was deleted.

28 changes: 0 additions & 28 deletions spec/acceptance/nodesets/new/aio/ubuntu-1404-64mda.yml

This file was deleted.

28 changes: 0 additions & 28 deletions spec/acceptance/nodesets/new/aio/ubuntu-1604-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/centos-5-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/centos-6-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/centos-7-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/debian-6-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/debian-7-64mda.yml

This file was deleted.

28 changes: 0 additions & 28 deletions spec/acceptance/nodesets/new/pe/debian-8-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/oracle-5-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/oracle-6-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/oracle-7-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/redhat-5-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/redhat-6-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/redhat-7-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/scientific-5-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/scientific-6-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/scientific-7-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/sles-10-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/sles-11-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/sles-12-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/ubuntu-1004-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/ubuntu-1204-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/ubuntu-1404-64mda.yml

This file was deleted.

27 changes: 0 additions & 27 deletions spec/acceptance/nodesets/new/pe/ubuntu-1604-64mda.yml

This file was deleted.

25 changes: 15 additions & 10 deletions spec/fixtures/iptables/conversion_hash.rb
Original file line number Diff line number Diff line change
Expand Up @@ -234,38 +234,43 @@
},
},
'comment_string_character_validation' => {
line: '-A INPUT -s 192.168.0.1/32 -m comment --comment "000 allow from 192.168.0.1, please"',
line: '-A INPUT -s 192.168.0.1/32 -m comment --comment "000 allow from 192.168.0.1, please" -j ACCEPT',
table: 'filter',
params: {
source: '192.168.0.1/32',
action: 'accept',
},
},
'multiple_comments' => {
line: '-A INPUT -s 192.168.0.1/32 -m comment --comment "000 allow from 192.168.0.1, please" -m comment --comment "another comment"',
line: '-A INPUT -s 192.168.0.1/32 -m comment --comment "000 allow from 192.168.0.1, please" -m comment --comment "another comment" -j ACCEPT',
table: 'filter',
params: {
name: '000 allow from 192.168.0.1, please;another comment',
action: 'accept',
},
},
'comments_without_quotes' => {
line: '-A INPUT -s 192.168.0.1/32 -m comment --comment comment_without_quotes',
'comments_without_quotes_with_underscores' => {
line: '-A INPUT -s 192.168.0.1/32 -m comment --comment comment_without_quotes -j ACCEPT',
table: 'filter',
params: {
name: '9000 comment_without_quotes',
action: 'accept',
},
},
'comments_without_quotes' => {
line: '-A INPUT -s 192.168.0.1/32 -m comment --comment 100-comment_without-quotes',
'comments_without_quotes_with_dashes' => {
line: '-A INPUT -s 192.168.0.1/32 -m comment --comment 100-comment_without-quotes -j ACCEPT',
table: 'filter',
params: {
name: '100-comment_without-quotes',
action: 'accept',
},
},
'string_escape_sequences' => {
line: '-A INPUT -m comment --comment "000 parse escaped \\"s, \\"s, \\\'s, \\\'s, \\\\s and \\\\s"',
line: '-A INPUT -m comment --comment "000 parse escaped \\"s, \\"s, \\\'s, \\\'s, \\\\s and \\\\s" -j ACCEPT',
table: 'filter',
params: {
name: '000 parse escaped "s, "s, \'s, \'s, \\s and \\s',
action: 'accept',
},
},
'log_level_debug' => {
Expand Down Expand Up @@ -1385,7 +1390,7 @@
table: 'filter',
string: 'GET /index.html',
},
args: ['-t', :filter, '-p', :tcp, '-m', 'string', '--string', "'GET /index.html'", '-m', 'comment', '--comment', '000 string_matching'],
args: ['-t', :filter, '-p', :tcp, '-m', 'string', '--string', "GET /index.html", '-m', 'comment', '--comment', '000 string_matching'],
},
'string_matching_2' => {
params: {
Expand All @@ -1394,7 +1399,7 @@
string: 'GET /index.html',
string_algo: 'bm',
},
args: ['-t', :filter, '-p', :tcp, '-m', 'string', '--string', "'GET /index.html'", '--algo', :bm, '-m', 'comment', '--comment', '000 string_matching'],
args: ['-t', :filter, '-p', :tcp, '-m', 'string', '--string', "GET /index.html", '--algo', :bm, '-m', 'comment', '--comment', '000 string_matching'],
},
'string_matching_3' => {
params: {
Expand All @@ -1404,7 +1409,7 @@
string_from: '1',
string_to: '65535',
},
args: ['-t', :filter, '-p', :tcp, '-m', 'string', '--string', "'GET /index.html'", '--from', '1', '--to', '65535', '-m', 'comment', '--comment', '000 string_matching'],
args: ['-t', :filter, '-p', :tcp, '-m', 'string', '--string', "GET /index.html", '--from', '1', '--to', '65535', '-m', 'comment', '--comment', '000 string_matching'],
},
'nfqueue_jump1' => {
params: {
Expand Down
6 changes: 5 additions & 1 deletion spec/spec_helper_acceptance_local.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ def ip6tables_flush_all_tables
def install_iptables
run_shell('iptables -V')
rescue
run_shell('apt-get install iptables -y')
if os[:family] == 'redhat'
run_shell('yum install iptables-services -y')
else
run_shell('apt-get install iptables -y')
end
end

def iptables_version
Expand Down