Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora 34 and iptables-compat fix; properly utilising iptables param. #1018

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

adamboutcher
Copy link
Contributor

@adamboutcher adamboutcher commented Sep 28, 2021

Improvement on PR - #1016 (#1016 (comment))
See BUG - https://tickets.puppetlabs.com/browse/MODULES-11147

This minor change to the package to use the name field and param should also mean supporting other distros/package names be much easier, where as prior it was static.

Completely untested on Debian Distros; Tested on CentOS7, Fedora 33, Fedora 34. Can't forsee any issues.

@adamboutcher adamboutcher requested a review from a team as a code owner September 28, 2021 15:32
@puppet-community-rangefinder
Copy link

firewall::linux is a class

that may have no external impact to Forge modules.

firewall::params is a class

that may have no external impact to Forge modules.

This module is declared in 106 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2021

CLA assistant check
All committers have signed the CLA.

@adamboutcher adamboutcher changed the title Fedora 34 and iptables-compat fix; properly utilising iptables variable. Fedora 34 and iptables-compat fix; properly utilising iptables param. Sep 28, 2021
@adrianiurca
Copy link
Contributor

Seems something not working properly because almost all tests are failing

@adamboutcher
Copy link
Contributor Author

Ah, I think I can see why, it seems $package_name is used differently to how I expected...

@adamboutcher
Copy link
Contributor Author

Hopefully those changes should improve things. Apologies, I've not got enough infrastructure to personally test this and the previous changes worked on Fedora 34.

@adamboutcher
Copy link
Contributor Author

adamboutcher commented Oct 4, 2021

As well as fixing the Fedora 34 issue, this PR moves the iptables package name into params called iptables_name, it should allow the package names to be more separate from the installation code.

@adrianiurca adrianiurca merged commit 77d4dd9 into puppetlabs:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants