Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CentOS Stream 9 Support (should include RHEL9 when that releases) #1028

Merged
merged 2 commits into from
May 16, 2022

Conversation

tskirvin
Copy link
Contributor

CentOS Stream 9 and RHEL9 are firewalld based, so we need to add more hooks to at least not get in the way of firewalld.

@tskirvin tskirvin requested a review from a team as a code owner February 14, 2022 16:25
@puppet-community-rangefinder
Copy link

firewall::linux::redhat is a class

that may have no external impact to Forge modules.

firewall::params is a class

that may have no external impact to Forge modules.

This module is declared in 106 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@github-actions
Copy link

This PR has been marked as stale because it has been open for a while and has had no recent activity. If this PR is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Apr 30, 2022
@tskirvin
Copy link
Contributor Author

tskirvin commented May 1, 2022

I still need this to be reviewed, please?

@github-actions github-actions bot removed the stale label May 2, 2022
@LukasAud
Copy link
Contributor

LukasAud commented May 2, 2022

Hi @tskirvin, thanks for coming back to us, we will be moving your PR back to active issues shortly.

Currently, we are using our stale-bot as a means to separate outdated and/or no longer relevant PRs from those that are still important for our community. It may, however, take a bit longer before we can perform a PR review as we are currently overloaded with them. Thank you for your patience.

@LukasAud
Copy link
Contributor

This change looks good to me, so I'll go ahead and merge it.

One thing to note tho, any changes to the CHANGELOG.md will be automatically removed by the release system, so its not really worth editing that file.

@LukasAud LukasAud merged commit 3f4619e into puppetlabs:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants