Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-1055) Fix for --random-fully #1058

Merged
merged 2 commits into from
Oct 3, 2022
Merged

(GH-1055) Fix for --random-fully #1058

merged 2 commits into from
Oct 3, 2022

Conversation

david22swan
Copy link
Member

Issues have arisen with the --random-fully value on certain RedHat versions.
It seem's as if the logic put in around --random and --random-fully are no longer working.
This change should resolve the issue and tighten the logic around the known_boolean values.

@david22swan david22swan mentioned this pull request Jul 13, 2022
Closed
@david22swan david22swan force-pushed the maint/main/random_fully branch 2 times, most recently from b8f2f22 to 842a42b Compare July 22, 2022 12:00
@david22swan
Copy link
Member Author

hmmmm, fix for the spec test breaks the acceptance tests

@pgrant87
Copy link

The customer has responded in a new support ticket this morning, the fix works as expected! Can we expect this to get merged and released once the tests have been fixed?

@david22swan
(puppetlabsGH-1055) Fix for --random-fully
fea215e 
Issues have arisen with the --random-fully value on certain RedHat versions.
It seem's as if the logic put in around `--random` and `--random-fully` are no longer working.
This change should resolve the issue and tighten the logic around the `known_boolean` values.
@david22swan
(maint) Fix for negated physdev_is_*
b1b0408 
Why confirming that this fix worked as intended it was shown that in fixing the original issue a second one had been uncovered.
This should fix the second one without infringing on the first fix.
@david22swan
Copy link
Member Author

david22swan commented Sep 28, 2022 •
edited
Loading

@pgrant87 Hey, sorry for the wait on this.
Hadn't seen the notification that you got back to me on it, must have missed it.
Anyway did a bit of confirmation work on the fix and discovered that it had caused/unearthed a separate issue, which I know have a fix up for as well, but wanted to make sure that the new fix didn't infringe on the old one, if you could get the customer to give it one last check before I have it merged.
Again sorry for the wait

@pgrant87
Copy link

The customer came back "I’ve re-deployed the code to ensure the new commit is included, run Puppet and haven’t seen any further issues!" looks good to go David!

@david22swan david22swan marked this pull request as ready for review October 3, 2022 10:01
@david22swan david22swan requested a review from a team as a code owner October 3, 2022 10:01
@chelnak chelnak merged commit 6346230 into puppetlabs:main Oct 3, 2022
@david22swan david22swan deleted the maint/main/random_fully branch June 5, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelnak chelnak chelnak approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david22swan @pgrant87 @chelnak